Commit ba60c41a authored Sep 02, 2015 by Sudip Mukherjee Committed by Paolo Bonzini Sep 08, 2015

kvm: irqchip: fix memory leak



We were taking the exit path after checking ue->flags and return value
of setup_routing_entry(), but 'e' was not freed incase of a failure.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 3dfe6a50

virt/kvm/irqchip.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -213,11 +213,15 @@ int kvm_set_irq_routing(struct kvm *kvm,
		goto out;

		r = -EINVAL;
		if (ue->flags)
		if (ue->flags) {
		kfree(e);
		goto out;
		}
		r = setup_routing_entry(new, e, ue);
		if (r)
		if (r) {
		kfree(e);
		goto out;
		}
		++ue;
		}