Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b97390ae authored by NeilBrown's avatar NeilBrown
Browse files

md/raid5: protect debug message against NULL derefernce. 



The pr_debug in add_stripe_bio could race with something
changing *bip, so it is best to hold the lock until
after the pr_debug.

Reported-by: default avatar"Jianpeng Ma" <majianpeng@gmail.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 143c4d05

drivers/md/raid5.c

+1 −1
Original line number Diff line number Diff line
@@ -2436,11 +2436,11 @@ static int add_stripe_bio(struct stripe_head *sh, struct bio *bi, int dd_idx, in 
		if (sector >= sh->dev[dd_idx].sector + STRIPE_SECTORS)

			set_bit(R5_OVERWRITE, &sh->dev[dd_idx].flags);

	}

	spin_unlock_irq(&sh->stripe_lock);



	pr_debug("added bi b#%llu to stripe s#%llu, disk %d.\n",

		(unsigned long long)(*bip)->bi_sector,

		(unsigned long long)sh->sector, dd_idx);

	spin_unlock_irq(&sh->stripe_lock);



	if (conf->mddev->bitmap && firstwrite) {

		bitmap_startwrite(conf->mddev->bitmap, sh->sector,