Commit b84caae4 authored Dec 16, 2013 by Himanshu Madhani Committed by David S. Miller Dec 17, 2013

qlcnic: Fix usage of netif_tx_{wake, stop} api during link change.



o Driver was using netif_tx_{stop,wake}_all_queues() api
  during link change event. Remove these api calls to
  manage queue start/stop event, as core networking stack
  will manage this based on netif_carrier_{on,off} call.
  These API's were modified as part of commit id
  012ec812 ("qlcnic: Multi Tx
  queue support for 82xx Series adapter.")

Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7022ef8b

drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c

+2 −8

Original line number	Diff line number	Diff line
		@@ -687,17 +687,11 @@ void qlcnic_advert_link_change(struct qlcnic_adapter *adapter, int linkup)
		if (adapter->ahw->linkup && !linkup) {
		netdev_info(netdev, "NIC Link is down\n");
		adapter->ahw->linkup = 0;
		if (netif_running(netdev)) {
		netif_carrier_off(netdev);
		netif_tx_stop_all_queues(netdev);
		}
		} else if (!adapter->ahw->linkup && linkup) {
		netdev_info(netdev, "NIC Link is up\n");
		adapter->ahw->linkup = 1;
		if (netif_running(netdev)) {
		netif_carrier_on(netdev);
		netif_wake_queue(netdev);
		}
		}
		}