Commit b74c4315 authored Jul 18, 2017 by Frank Rowand Committed by Peter Chen Jul 19, 2017

usb: chipidea: msm: ci_hdrc_msm_probe() missing of_node_get()



Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error:
OF: ERROR: Bad of_node_put() on /soc/usb@f9a55000

The error will occur if the configuration is set to:
   CONFIG_OF_OVERLAY y
   CONFIG_OF_UNITTEST y
   CONFIG_OF_DYNAMIC y
   CONFIG_OF_RESOLVE y

If CONFIG_OF_DYNAMIC is enabled then of_node_release() detects an
attempt to release a node that is still attached to the device tree.

Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>

parent 734c58ae

drivers/usb/chipidea/ci_hdrc_msm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -251,7 +251,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
		if (ret)
		goto err_mux;

		ulpi_node = of_find_node_by_name(pdev->dev.of_node, "ulpi");
		ulpi_node = of_find_node_by_name(of_node_get(pdev->dev.of_node), "ulpi");
		if (ulpi_node) {
		phy_node = of_get_next_available_child(ulpi_node, NULL);
		ci->hsic = of_device_is_compatible(phy_node, "qcom,usb-hsic-phy");