Commit b7165ebb authored Jun 06, 2013 by Kees Cook Committed by Greg Kroah-Hartman Jun 07, 2013

kobject: sanitize argument for format string



Unlike kobject_set_name(), the kset_create_and_add() interface does not
provide a way to use format strings, so make sure that the interface
cannot be abused accidentally. It looks like all current callers use
static strings, so there's no existing flaw.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fc60bb83

lib/kobject.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -805,7 +805,7 @@ static struct kset kset_create(const char name,
		kset = kzalloc(sizeof(*kset), GFP_KERNEL);
		if (!kset)
		return NULL;
		retval = kobject_set_name(&kset->kobj, name);
		retval = kobject_set_name(&kset->kobj, "%s", name);
		if (retval) {
		kfree(kset);
		return NULL;