Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b7019b2f authored by Alex Deucher's avatar Alex Deucher Committed by Dave Airlie
Browse files

drm/radeon: SI tiling fixes for display 



- Use the correct union for getting the tiling info
- Properly init the PIPE_CONFIG field for SI

Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarMichel Dänzer <michel.daenzer@amd.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent fb09185a

drivers/gpu/drm/radeon/atombios_crtc.c

+9 −1
Original line number Original line Diff line number Diff line
@@ -1149,7 +1149,9 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc, 
	}

	}





	if (tiling_flags & RADEON_TILING_MACRO) {

	if (tiling_flags & RADEON_TILING_MACRO) {

		if (rdev->family >= CHIP_CAYMAN)

		if (rdev->family >= CHIP_TAHITI)

			tmp = rdev->config.si.tile_config;

		else if (rdev->family >= CHIP_CAYMAN)

			tmp = rdev->config.cayman.tile_config;

			tmp = rdev->config.cayman.tile_config;

		else

		else

			tmp = rdev->config.evergreen.tile_config;

			tmp = rdev->config.evergreen.tile_config;
@@ -1177,6 +1179,12 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc, 
	} else if (tiling_flags & RADEON_TILING_MICRO)

	} else if (tiling_flags & RADEON_TILING_MICRO)

		fb_format |= EVERGREEN_GRPH_ARRAY_MODE(EVERGREEN_GRPH_ARRAY_1D_TILED_THIN1);

		fb_format |= EVERGREEN_GRPH_ARRAY_MODE(EVERGREEN_GRPH_ARRAY_1D_TILED_THIN1);





	if ((rdev->family == CHIP_TAHITI) ||

	    (rdev->family == CHIP_PITCAIRN))

		fb_format |= SI_GRPH_PIPE_CONFIG(SI_ADDR_SURF_P8_32x32_8x16);

	else if (rdev->family == CHIP_VERDE)

		fb_format |= SI_GRPH_PIPE_CONFIG(SI_ADDR_SURF_P4_8x16);



	switch (radeon_crtc->crtc_id) {

	switch (radeon_crtc->crtc_id) {

	case 0:

	case 0:

		WREG32(AVIVO_D1VGA_CONTROL, 0);

		WREG32(AVIVO_D1VGA_CONTROL, 0);

drivers/gpu/drm/radeon/si_reg.h

+72 −0
Original line number Original line Diff line number Diff line
@@ -30,4 +30,76 @@ 
#define SI_DC_GPIO_HPD_EN                        0x65b8

#define SI_DC_GPIO_HPD_EN                        0x65b8

#define SI_DC_GPIO_HPD_Y                         0x65bc

#define SI_DC_GPIO_HPD_Y                         0x65bc





#define SI_GRPH_CONTROL                          0x6804

#       define SI_GRPH_DEPTH(x)                  (((x) & 0x3) << 0)

#       define SI_GRPH_DEPTH_8BPP                0

#       define SI_GRPH_DEPTH_16BPP               1

#       define SI_GRPH_DEPTH_32BPP               2

#       define SI_GRPH_NUM_BANKS(x)              (((x) & 0x3) << 2)

#       define SI_ADDR_SURF_2_BANK               0

#       define SI_ADDR_SURF_4_BANK               1

#       define SI_ADDR_SURF_8_BANK               2

#       define SI_ADDR_SURF_16_BANK              3

#       define SI_GRPH_Z(x)                      (((x) & 0x3) << 4)

#       define SI_GRPH_BANK_WIDTH(x)             (((x) & 0x3) << 6)

#       define SI_ADDR_SURF_BANK_WIDTH_1         0

#       define SI_ADDR_SURF_BANK_WIDTH_2         1

#       define SI_ADDR_SURF_BANK_WIDTH_4         2

#       define SI_ADDR_SURF_BANK_WIDTH_8         3

#       define SI_GRPH_FORMAT(x)                 (((x) & 0x7) << 8)

/* 8 BPP */

#       define SI_GRPH_FORMAT_INDEXED            0

/* 16 BPP */

#       define SI_GRPH_FORMAT_ARGB1555           0

#       define SI_GRPH_FORMAT_ARGB565            1

#       define SI_GRPH_FORMAT_ARGB4444           2

#       define SI_GRPH_FORMAT_AI88               3

#       define SI_GRPH_FORMAT_MONO16             4

#       define SI_GRPH_FORMAT_BGRA5551           5

/* 32 BPP */

#       define SI_GRPH_FORMAT_ARGB8888           0

#       define SI_GRPH_FORMAT_ARGB2101010        1

#       define SI_GRPH_FORMAT_32BPP_DIG          2

#       define SI_GRPH_FORMAT_8B_ARGB2101010     3

#       define SI_GRPH_FORMAT_BGRA1010102        4

#       define SI_GRPH_FORMAT_8B_BGRA1010102     5

#       define SI_GRPH_FORMAT_RGB111110          6

#       define SI_GRPH_FORMAT_BGR101111          7

#       define SI_GRPH_BANK_HEIGHT(x)            (((x) & 0x3) << 11)

#       define SI_ADDR_SURF_BANK_HEIGHT_1        0

#       define SI_ADDR_SURF_BANK_HEIGHT_2        1

#       define SI_ADDR_SURF_BANK_HEIGHT_4        2

#       define SI_ADDR_SURF_BANK_HEIGHT_8        3

#       define SI_GRPH_TILE_SPLIT(x)             (((x) & 0x7) << 13)

#       define SI_ADDR_SURF_TILE_SPLIT_64B       0

#       define SI_ADDR_SURF_TILE_SPLIT_128B      1

#       define SI_ADDR_SURF_TILE_SPLIT_256B      2

#       define SI_ADDR_SURF_TILE_SPLIT_512B      3

#       define SI_ADDR_SURF_TILE_SPLIT_1KB       4

#       define SI_ADDR_SURF_TILE_SPLIT_2KB       5

#       define SI_ADDR_SURF_TILE_SPLIT_4KB       6

#       define SI_GRPH_MACRO_TILE_ASPECT(x)      (((x) & 0x3) << 18)

#       define SI_ADDR_SURF_MACRO_TILE_ASPECT_1  0

#       define SI_ADDR_SURF_MACRO_TILE_ASPECT_2  1

#       define SI_ADDR_SURF_MACRO_TILE_ASPECT_4  2

#       define SI_ADDR_SURF_MACRO_TILE_ASPECT_8  3

#       define SI_GRPH_ARRAY_MODE(x)             (((x) & 0x7) << 20)

#       define SI_GRPH_ARRAY_LINEAR_GENERAL      0

#       define SI_GRPH_ARRAY_LINEAR_ALIGNED      1

#       define SI_GRPH_ARRAY_1D_TILED_THIN1      2

#       define SI_GRPH_ARRAY_2D_TILED_THIN1      4

#       define SI_GRPH_PIPE_CONFIG(x)		 (((x) & 0x1f) << 24)

#       define SI_ADDR_SURF_P2			 0

#       define SI_ADDR_SURF_P4_8x16		 4

#       define SI_ADDR_SURF_P4_16x16		 5

#       define SI_ADDR_SURF_P4_16x32		 6

#       define SI_ADDR_SURF_P4_32x32		 7

#       define SI_ADDR_SURF_P8_16x16_8x16	 8

#       define SI_ADDR_SURF_P8_16x32_8x16	 9

#       define SI_ADDR_SURF_P8_32x32_8x16	 10

#       define SI_ADDR_SURF_P8_16x32_16x16	 11

#       define SI_ADDR_SURF_P8_32x32_16x16	 12

#       define SI_ADDR_SURF_P8_32x32_16x32	 13

#       define SI_ADDR_SURF_P8_32x64_32x32	 14



#endif
 
#endif