Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6f6fd8a authored by Ioana Ciornei's avatar Ioana Ciornei Committed by Greg Kroah-Hartman
Browse files

stating: gdm724x: remove explicit NULL comparison 



This patch converts explicit NULL comparison to its shorter
equivalent form.
Done with coccinelle semantic patch:

@@
expression e;
@@

- e == NULL
+ !e

Signed-off-by: default avatarIoana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a4785ef8

drivers/staging/gdm724x/gdm_lte.c

+2 −2
Original line number Diff line number Diff line
@@ -775,7 +775,7 @@ static int gdm_lte_receive_pkt(struct phy_dev *phy_dev, char *buf, int len) 
				   hci->cmd_evt);



	dev = phy_dev->dev[0];

	if (dev == NULL)

	if (!dev)

		return 0;



	switch (cmd_evt) {
@@ -938,7 +938,7 @@ void unregister_lte_device(struct phy_dev *phy_dev) 


	for (index = 0; index < MAX_NIC_TYPE; index++) {

		net = phy_dev->dev[index];

		if (net == NULL)

		if (!net)

			continue;



		unregister_netdev(net);

drivers/staging/gdm724x/gdm_mux.c

+2 −2
Original line number Diff line number Diff line
@@ -492,7 +492,7 @@ static int init_usb(struct mux_dev *mux_dev) 


	for (i = 0; i < MAX_ISSUE_NUM * 2; i++) {

		r = alloc_mux_rx();

		if (r == NULL) {

		if (!r) {

			ret = -ENOMEM;

			break;

		}
@@ -662,7 +662,7 @@ static int __init gdm_usb_mux_init(void) 
{



	mux_rx_wq = create_workqueue("mux_rx_wq");

	if (mux_rx_wq == NULL) {

	if (!mux_rx_wq) {

		pr_err("work queue create fail\n");

		return -1;

	}

drivers/staging/gdm724x/gdm_tty.c

+1 −1
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ static int gdm_tty_install(struct tty_driver *driver, struct tty_struct *tty) 


	mutex_lock(&gdm_table_lock);

	gdm = gdm_table[i][j];

	if (gdm == NULL) {

	if (!gdm) {

		mutex_unlock(&gdm_table_lock);

		return -ENODEV;

	}

drivers/staging/gdm724x/gdm_usb.c

+8 −8
Original line number Diff line number Diff line
@@ -338,7 +338,7 @@ static int init_usb(struct lte_udev *udev) 


	for (i = 0; i < MAX_NUM_SDU_BUF; i++) {

		t_sdu = alloc_tx_sdu_struct();

		if (t_sdu == NULL) {

		if (!t_sdu) {

			ret = -ENOMEM;

			goto fail;

		}
@@ -349,7 +349,7 @@ static int init_usb(struct lte_udev *udev) 


	for (i = 0; i < MAX_RX_SUBMIT_COUNT*2; i++) {

		r = alloc_rx_struct();

		if (r == NULL) {

		if (!r) {

			ret = -ENOMEM;

			goto fail;

		}
@@ -682,7 +682,7 @@ static void do_tx(struct work_struct *work) 
		}



		t = alloc_tx_struct(TX_BUF_SIZE);

		if (t == NULL) {

		if (!t) {

			spin_unlock_irqrestore(&tx->lock, flags);

			return;

		}
@@ -732,7 +732,7 @@ static int gdm_usb_sdu_send(void *priv_dev, void *data, int len, 
	t_sdu = get_tx_sdu_struct(tx, &no_spc);

	spin_unlock_irqrestore(&tx->lock, flags);



	if (t_sdu == NULL) {

	if (!t_sdu) {

		pr_err("sdu send - free list empty\n");

		return TX_NO_SPC;

	}
@@ -782,7 +782,7 @@ static int gdm_usb_hci_send(void *priv_dev, void *data, int len, 
	}



	t = alloc_tx_struct(len);

	if (t == NULL) {

	if (!t) {

		pr_err("hci_send - out of memory\n");

		return -ENOMEM;

	}
@@ -1006,11 +1006,11 @@ static int __init gdm_usb_lte_init(void) 
	}



	usb_tx_wq = create_workqueue("usb_tx_wq");

	if (usb_tx_wq == NULL)

	if (!usb_tx_wq)

		return -1;



	usb_rx_wq = create_workqueue("usb_rx_wq");

	if (usb_rx_wq == NULL)

	if (!usb_rx_wq)

		return -1;



	return usb_register(&gdm_usb_lte_driver);

drivers/staging/gdm724x/netlink_k.c

+1 −1

File changed.

Contains only whitespace changes.