Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6a99e96 authored by Oleh Kravchenko's avatar Oleh Kravchenko Committed by Greg Kroah-Hartman
Browse files

led: triggers: Fix dereferencing of null pointer 



[ Upstream commit 4016ba85880b252365d11bc7dc899450f2c73ad7 ]

Error was detected by PVS-Studio:
V522 Dereferencing of the null pointer 'led_cdev->trigger' might take place.

Fixes: 2282e125 ("leds: triggers: let struct led_trigger::activate() return an error code")
Signed-off-by: default avatarOleh Kravchenko <oleg@kaa.org.ua>
Reviewed-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarJacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 43a80754

drivers/leds/led-triggers.c

+2 −2
Original line number Diff line number Diff line
@@ -171,11 +171,11 @@ int led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig) 
		trig->deactivate(led_cdev);

err_activate:



	led_cdev->trigger = NULL;

	led_cdev->trigger_data = NULL;

	write_lock_irqsave(&led_cdev->trigger->leddev_list_lock, flags);

	list_del(&led_cdev->trig_list);

	write_unlock_irqrestore(&led_cdev->trigger->leddev_list_lock, flags);

	led_cdev->trigger = NULL;

	led_cdev->trigger_data = NULL;

	led_set_brightness(led_cdev, LED_OFF);

	kfree(event);