Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b64a097a authored by Linus Walleij's avatar Linus Walleij Committed by Jonathan Cameron
Browse files

iio: gyro: mpu3050: Allow open drain with anything 



Open drain should work fine with rising or high level IRQs,
this code was due to some misunderstanding on my part.

Reported-by: default avatarLorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent ea5c6e26

drivers/iio/gyro/mpu3050-core.c

+0 −10
Original line number Diff line number Diff line
@@ -1063,11 +1063,6 @@ static int mpu3050_trigger_probe(struct iio_dev *indio_dev, int irq) 
	case IRQF_TRIGGER_RISING:

		dev_info(&indio_dev->dev,

			 "pulse interrupts on the rising edge\n");

		if (mpu3050->irq_opendrain) {

			dev_info(&indio_dev->dev,

				 "rising edge incompatible with open drain\n");

			mpu3050->irq_opendrain = false;

		}

		break;

	case IRQF_TRIGGER_FALLING:

		mpu3050->irq_actl = true;
@@ -1078,11 +1073,6 @@ static int mpu3050_trigger_probe(struct iio_dev *indio_dev, int irq) 
		mpu3050->irq_latch = true;

		dev_info(&indio_dev->dev,

			 "interrupts active high level\n");

		if (mpu3050->irq_opendrain) {

			dev_info(&indio_dev->dev,

				 "active high incompatible with open drain\n");

			mpu3050->irq_opendrain = false;

		}

		/*

		 * With level IRQs, we mask the IRQ until it is processed,

		 * but with edge IRQs (pulses) we can queue several interrupts