Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b62df58c authored by Marcel Holtmann's avatar Marcel Holtmann Committed by Greg Kroah-Hartman
Browse files

HID: hidraw: Fix returning EPOLLOUT from hidraw_poll 



[ Upstream commit 9f3b61dc1dd7b81e99e7ed23776bb64a35f39e1a ]

When polling a connected /dev/hidrawX device, it is useful to get the
EPOLLOUT when writing is possible. Since writing is possible as soon as
the device is connected, always return it.

Right now EPOLLOUT is only returned when there are also input reports
are available. This works if devices start sending reports when
connected, but some HID devices might need an output report first before
sending any input reports. This change will allow using EPOLLOUT here as
well.

Fixes: 378b80370aa1 ("hidraw: Return EPOLLOUT from hidraw_poll")
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d2178fc8

drivers/hid/hidraw.c

+2 −2
Original line number Diff line number Diff line
@@ -260,10 +260,10 @@ static __poll_t hidraw_poll(struct file *file, poll_table *wait) 


	poll_wait(file, &list->hidraw->wait, wait);

	if (list->head != list->tail)

		return EPOLLIN | EPOLLRDNORM | EPOLLOUT;

		return EPOLLIN | EPOLLRDNORM;

	if (!list->hidraw->exist)

		return EPOLLERR | EPOLLHUP;

	return 0;

	return EPOLLOUT | EPOLLWRNORM;

}



static int hidraw_open(struct inode *inode, struct file *file)