Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b605687c authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Mauro Carvalho Chehab
Browse files

media: staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR 



Fix inconsistent IS_ERR and PTR_ERR in vdic_get_ipu_resources.
The proper pointer to be passed as argument is ch.

This issue was detected with the help of Coccinelle.

Fixes: 0b2e9e79 ("media: staging/imx: remove confusing IS_ERR_OR_NULL usage")

Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: default avatarSteve Longerbeam <steve_longerbeam@mentor.com>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent ee9568aa

drivers/staging/media/imx/imx-media-vdic.c

+1 −1
Original line number Diff line number Diff line
@@ -177,7 +177,7 @@ static int vdic_get_ipu_resources(struct vdic_priv *priv) 
		priv->vdi_in_ch = ch;



		ch = ipu_idmac_get(priv->ipu, IPUV3_CHANNEL_MEM_VDI_NEXT);

		if (IS_ERR(priv->vdi_in_ch_n)) {

		if (IS_ERR(ch)) {

			err_chan = IPUV3_CHANNEL_MEM_VDI_NEXT;

			ret = PTR_ERR(ch);

			goto out_err_chan;