Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5bc5981 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Doug Ledford
Browse files

RDMA/uverbs: Convert command mask validity check function to be bool 



The function validate_command_mask() returns only two results: success
or failure, so convert it to return bool instead of 0 and -1.

Reported-by: default avatarNoa Osherovich <noaos@mellanox.com>
Reviewed-by: default avatarMatan Barak <matanb@mellanox.com>
Reviewed-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 4bb46608

drivers/infiniband/core/uverbs_main.c

+4 −4
Original line number Diff line number Diff line
@@ -635,7 +635,7 @@ struct file *ib_uverbs_alloc_async_event_file(struct ib_uverbs_file *uverbs_file 
	return filp;

}



static int verify_command_mask(struct ib_device *ib_dev, __u32 command)

static bool verify_command_mask(struct ib_device *ib_dev, __u32 command)

{

	u64 mask;
@@ -645,9 +645,9 @@ static int verify_command_mask(struct ib_device *ib_dev, __u32 command) 
		mask = ib_dev->uverbs_ex_cmd_mask;



	if (mask & ((u64)1 << command))

		return 0;

		return true;



	return -1;

	return false;

}



static bool verify_command_idx(u32 command, bool extended)
@@ -706,7 +706,7 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, 
		goto out;

	}



	if (verify_command_mask(ib_dev, command)) {

	if (!verify_command_mask(ib_dev, command)) {

		ret = -EOPNOTSUPP;

		goto out;

	}