Commit b5603a94 authored Feb 02, 2015 by Mauro Carvalho Chehab

[media] cx231xx: don't use dev it not allocated



changeset 5eeb3014 added a fixup at the error check
code. However, it introduced a new error:

	drivers/media/usb/cx231xx/cx231xx-cards.c:1586 cx231xx_usb_probe() error: we previously assumed 'dev' could be null (see line 1430)

This happens when dev = kmalloc() fails. So, instead of relying
on it to succeed, just change the parameter of clear_bit() from
'dev->devno' to 'nr'.

Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

parent 5eeb3014

drivers/media/usb/cx231xx/cx231xx-cards.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1583,7 +1583,7 @@ static int cx231xx_usb_probe(struct usb_interface *interface,
		usb_set_intfdata(interface, NULL);
		err_if:
		usb_put_dev(udev);
		clear_bit(dev->devno, &cx231xx_devused);
		clear_bit(nr, &cx231xx_devused);
		return retval;
		}