Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b54143be authored by Mustafa Ismail's avatar Mustafa Ismail Committed by Doug Ledford
Browse files

i40iw: Remove unnecessary parameter to i40iw_cq_poll_completion 



Post_cq parameter passed to i40iw_cq_poll_completion is always
true; so remove.

Signed-off-by: default avatarMustafa Ismail <mustafa.ismail@intel.com>
Signed-off-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 5ec11ed2

drivers/infiniband/hw/i40iw/i40iw_uk.c

+4 −7
Original line number Diff line number Diff line
@@ -753,8 +753,7 @@ static enum i40iw_status_code i40iw_cq_post_entries(struct i40iw_cq_uk *cq, 
 * @post_cq: update cq tail

 */

static enum i40iw_status_code i40iw_cq_poll_completion(struct i40iw_cq_uk *cq,

						       struct i40iw_cq_poll_info *info,

						       bool post_cq)

						       struct i40iw_cq_poll_info *info)

{

	u64 comp_ctx, qword0, qword2, qword3, wqe_qword;

	u64 *cqe, *sw_wqe;
@@ -878,11 +877,9 @@ static enum i40iw_status_code i40iw_cq_poll_completion(struct i40iw_cq_uk *cq, 
		if (I40IW_RING_GETCURRENT_HEAD(cq->cq_ring) == 0)

			cq->polarity ^= 1;



		if (post_cq) {

		I40IW_RING_MOVE_TAIL(cq->cq_ring);

		set_64bit_val(cq->shadow_area, 0,

			      I40IW_RING_GETCURRENT_HEAD(cq->cq_ring));

		}

	} else {

		if (info->is_srq)

			return ret_code;

drivers/infiniband/hw/i40iw/i40iw_user.h

+1 −1
Original line number Diff line number Diff line
@@ -327,7 +327,7 @@ struct i40iw_cq_ops { 
	void (*iw_cq_request_notification)(struct i40iw_cq_uk *,

					   enum i40iw_completion_notify);

	enum i40iw_status_code (*iw_cq_poll_completion)(struct i40iw_cq_uk *,

							struct i40iw_cq_poll_info *, bool);

							struct i40iw_cq_poll_info *);

	enum i40iw_status_code (*iw_cq_post_entries)(struct i40iw_cq_uk *, u8 count);

	void (*iw_cq_clean)(void *, struct i40iw_cq_uk *);

};

drivers/infiniband/hw/i40iw/i40iw_verbs.c

+1 −1
Original line number Diff line number Diff line
@@ -2259,7 +2259,7 @@ static int i40iw_poll_cq(struct ib_cq *ibcq, 


	spin_lock_irqsave(&iwcq->lock, flags);

	while (cqe_count < num_entries) {

		ret = ukcq->ops.iw_cq_poll_completion(ukcq, &cq_poll_info, true);

		ret = ukcq->ops.iw_cq_poll_completion(ukcq, &cq_poll_info);

		if (ret == I40IW_ERR_QUEUE_EMPTY) {

			break;

		} else if (ret == I40IW_ERR_QUEUE_DESTROYED) {