Commit b4967aa5 authored Sep 17, 2012 by Thomas Abraham Committed by Chris Ball Oct 03, 2012

mmc: dw_mmc: add quirk to indicate missing write protect line



If the write protect pad of the controller is not connected to the write
protect pin of the slot, the driver should be notified of this condition
so that incorrect check for write protection by reading the WRTORT
register can avoided. The get_ro platform callback can be used for in
such cases, but with device tree support enabled, such platform callbacks
cannot be supported.

Add a new quirk for notifying the driver about the missing write protect
line so the driver can assume that the card write protection is disabled.

Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
Acked-by: Will Newton <will.newton@imgtec.com>
Signed-off-by: Chris Ball <cjb@laptop.org>

parent f90a0612

drivers/mmc/host/dw_mmc.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -830,7 +830,9 @@ static int dw_mci_get_ro(struct mmc_host *mmc)
		struct dw_mci_board *brd = slot->host->pdata;

		/* Use platform get_ro function, else try on board write protect */
		if (brd->get_ro)
		if (brd->quirks & DW_MCI_QUIRK_NO_WRITE_PROTECT)
		read_only = 0;
		else if (brd->get_ro)
		read_only = brd->get_ro(slot->id);
		else
		read_only =

include/linux/mmc/dw_mmc.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -205,7 +205,8 @@ struct dw_mci_dma_ops {
		#define DW_MCI_QUIRK_HIGHSPEED BIT(2)
		/* Unreliable card detection */
		#define DW_MCI_QUIRK_BROKEN_CARD_DETECTION BIT(3)

		/* Write Protect detection not available */
		#define DW_MCI_QUIRK_NO_WRITE_PROTECT BIT(4)

		struct dma_pdata;