Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b46980fe authored by David Howells's avatar David Howells Committed by Linus Torvalds
Browse files

iget: introduce a function to register iget failure 



Introduce a function to register failure in an inode construction path.  This
includes marking the inode under construction as bad, unlocking it and
releasing it.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Acked-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e231c2ee

Documentation/filesystems/porting

+13 −5
Original line number Diff line number Diff line
@@ -186,10 +186,18 @@ test and set for you. 
e.g.

	inode = iget_locked(sb, ino);

	if (inode->i_state & I_NEW) {

               read_inode_from_disk(inode);

		err = read_inode_from_disk(inode);

		if (err < 0) {

			iget_failed(inode);

			return err;

		}

		unlock_new_inode(inode);

	}



Note that if the process of setting up a new inode fails, then iget_failed()

should be called on the inode to render it dead, and an appropriate error

should be passed back to the caller.



---

[recommended]

fs/bad_inode.c

+14 −0
Original line number Diff line number Diff line
@@ -359,3 +359,17 @@ int is_bad_inode(struct inode *inode) 
}



EXPORT_SYMBOL(is_bad_inode);



/**

 * iget_failed - Mark an under-construction inode as dead and release it

 * @inode: The inode to discard

 *

 * Mark an under-construction inode as dead and release it.

 */

void iget_failed(struct inode *inode)

{

	make_bad_inode(inode);

	unlock_new_inode(inode);

	iput(inode);

}

EXPORT_SYMBOL(iget_failed);

include/linux/fs.h

+1 −0
Original line number Diff line number Diff line
@@ -1780,6 +1780,7 @@ static inline struct inode *iget(struct super_block *sb, unsigned long ino) 
}



extern void __iget(struct inode * inode);

extern void iget_failed(struct inode *);

extern void clear_inode(struct inode *);

extern void destroy_inode(struct inode *);

extern struct inode *new_inode(struct super_block *);