Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b420166f authored by Amitkumar Karwar's avatar Amitkumar Karwar Committed by Kalle Valo
Browse files

mwifiex: do not release lock during list_for_each_entry_safe() 



As we are releasing the lock, during next iteration we may end
up getting page fault if other thread has already deleted that
node.

Signed-off-by: default avatarCathy Luo <cluo@marvell.com>
Signed-off-by: default avatarAvinash Patil <patila@marvell.com>
Signed-off-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent fc647467

drivers/net/wireless/mwifiex/cmdevt.c

+0 −6
Original line number Diff line number Diff line
@@ -1008,11 +1008,9 @@ mwifiex_cancel_all_pending_cmd(struct mwifiex_adapter *adapter) 
	list_for_each_entry_safe(cmd_node, tmp_node,

				 &adapter->scan_pending_q, list) {

		list_del(&cmd_node->list);

		spin_unlock_irqrestore(&adapter->scan_pending_q_lock, flags);



		cmd_node->wait_q_enabled = false;

		mwifiex_insert_cmd_to_free_q(adapter, cmd_node);

		spin_lock_irqsave(&adapter->scan_pending_q_lock, flags);

	}

	spin_unlock_irqrestore(&adapter->scan_pending_q_lock, flags);
@@ -1070,12 +1068,8 @@ mwifiex_cancel_pending_ioctl(struct mwifiex_adapter *adapter) 
	list_for_each_entry_safe(cmd_node, tmp_node,

				 &adapter->scan_pending_q, list) {

		list_del(&cmd_node->list);

		spin_unlock_irqrestore(&adapter->scan_pending_q_lock,

				       scan_pending_q_flags);

		cmd_node->wait_q_enabled = false;

		mwifiex_insert_cmd_to_free_q(adapter, cmd_node);

		spin_lock_irqsave(&adapter->scan_pending_q_lock,

				  scan_pending_q_flags);

	}

	spin_unlock_irqrestore(&adapter->scan_pending_q_lock,

			       scan_pending_q_flags);