Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4087c2a authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

soc/tegra: pmc: Fix child-node lookup 



commit 1dc6bd5e39a29453bdcc17348dd2a89f1aa4004e upstream.

Fix child-node lookup during probe, which ended up searching the whole
device tree depth-first starting at the parent rather than just matching
on its children.

To make things worse, the parent pmc node could end up being prematurely
freed as of_find_node_by_name() drops a reference to its first argument.

Fixes: 3568df3d ("soc: tegra: Add thermal reset (thermtrip) support to PMC")
Cc: stable <stable@vger.kernel.org>     # 4.0
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarMikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7f9a150f

drivers/soc/tegra/pmc.c

+1 −1
Original line number Diff line number Diff line
@@ -1288,7 +1288,7 @@ static void tegra_pmc_init_tsense_reset(struct tegra_pmc *pmc) 
	if (!pmc->soc->has_tsense_reset)

		return;



	np = of_find_node_by_name(pmc->dev->of_node, "i2c-thermtrip");

	np = of_get_child_by_name(pmc->dev->of_node, "i2c-thermtrip");

	if (!np) {

		dev_warn(dev, "i2c-thermtrip node not found, %s.\n", disabled);

		return;