Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b33f9226 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf hists browser: Put hist_entry folding logic into single function 



It will be used in following patch to expand or collapse only the
current browser entry.

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1484904032-11040-2-git-send-email-jolsa@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 9343e45b

tools/perf/ui/browsers/hists.c

+25 −18
Original line number Diff line number Diff line
@@ -501,7 +501,7 @@ static int hierarchy_set_folding(struct hist_browser *hb, struct hist_entry *he, 
	return n;

}



static void hist_entry__set_folding(struct hist_entry *he,

static void __hist_entry__set_folding(struct hist_entry *he,

				      struct hist_browser *hb, bool unfold)

{

	hist_entry__init_have_children(he);
@@ -520,25 +520,16 @@ static void hist_entry__set_folding(struct hist_entry *he, 
		he->nr_rows = 0;

}



static void

__hist_browser__set_folding(struct hist_browser *browser, bool unfold)

static void hist_entry__set_folding(struct hist_entry *he,

				    struct hist_browser *browser, bool unfold)

{

	struct rb_node *nd;

	struct hist_entry *he;

	double percent;



	nd = rb_first(&browser->hists->entries);

	while (nd) {

		he = rb_entry(nd, struct hist_entry, rb_node);



		/* set folding state even if it's currently folded */

		nd = __rb_hierarchy_next(nd, HMD_FORCE_CHILD);



		hist_entry__set_folding(he, browser, unfold);



	percent = hist_entry__get_percent_limit(he);

	if (he->filtered || percent < browser->min_pcnt)

			continue;

		return;



	__hist_entry__set_folding(he, browser, unfold);



	if (!he->depth || unfold)

		browser->nr_hierarchy_entries++;
@@ -551,6 +542,22 @@ __hist_browser__set_folding(struct hist_browser *browser, bool unfold) 
	} else

		he->has_no_entry = false;

}



static void

__hist_browser__set_folding(struct hist_browser *browser, bool unfold)

{

	struct rb_node *nd;

	struct hist_entry *he;



	nd = rb_first(&browser->hists->entries);

	while (nd) {

		he = rb_entry(nd, struct hist_entry, rb_node);



		/* set folding state even if it's currently folded */

		nd = __rb_hierarchy_next(nd, HMD_FORCE_CHILD);



		hist_entry__set_folding(he, browser, unfold);

	}

}



static void hist_browser__set_folding(struct hist_browser *browser, bool unfold)