Commit b33d12d3 authored Mar 27, 2016 by Paul Gortmaker Committed by Linus Walleij Mar 31, 2016

gpio: xgene: make explicitly non-modular



The Kconfig currently controlling compilation of this code is:

drivers/gpio/Kconfig:config GPIO_XGENE
drivers/gpio/Kconfig:   bool "APM X-Gene GPIO controller support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Feng Kan <fkan@apm.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 3c90c6d6

drivers/gpio/gpio-xgene.c

+1 −8

Original line number	Diff line number	Diff line
		@@ -17,7 +17,6 @@
		* along with this program. If not, see <http://www.gnu.org/licenses/>.
		*/

		#include <linux/module.h>
		#include <linux/kernel.h>
		#include <linux/init.h>
		#include <linux/io.h>
		@@ -211,7 +210,6 @@ static const struct of_device_id xgene_gpio_of_match[] = {
		{ .compatible = "apm,xgene-gpio", },
		{},
		};
		MODULE_DEVICE_TABLE(of, xgene_gpio_of_match);

		static struct platform_driver xgene_gpio_driver = {
		.driver = {
		@@ -221,9 +219,4 @@ static struct platform_driver xgene_gpio_driver = {
		},
		.probe = xgene_gpio_probe,
		};

		module_platform_driver(xgene_gpio_driver);

		MODULE_AUTHOR("Feng Kan <fkan@apm.com>");
		MODULE_DESCRIPTION("APM X-Gene GPIO driver");
		MODULE_LICENSE("GPL");
		builtin_platform_driver(xgene_gpio_driver);