Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b32caece authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

net: plip: don't call kfree_skb/dev_kfree_skb() under spin_lock_irq() 



[ Upstream commit 7d8c19bfc8ff3f78e5337107ca9246327fcb6b45 ]

It is not allowed to call kfree_skb() or consume_skb() from
hardware interrupt context or with interrupts being disabled.
So replace kfree_skb/dev_kfree_skb() with dev_kfree_skb_irq()
and dev_consume_skb_irq() under spin_lock_irq().

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20221207015310.2984909-1-yangyingliang@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5215a8c7

drivers/net/plip/plip.c

+2 −2
Original line number Diff line number Diff line
@@ -448,12 +448,12 @@ plip_bh_timeout_error(struct net_device *dev, struct net_local *nl, 
	}

	rcv->state = PLIP_PK_DONE;

	if (rcv->skb) {

		kfree_skb(rcv->skb);

		dev_kfree_skb_irq(rcv->skb);

		rcv->skb = NULL;

	}

	snd->state = PLIP_PK_DONE;

	if (snd->skb) {

		dev_kfree_skb(snd->skb);

		dev_consume_skb_irq(snd->skb);

		snd->skb = NULL;

	}

	spin_unlock_irq(&nl->lock);