Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2f4de8b authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by Martin Schwidefsky
Browse files

s390: remove unneeded variables 



This patch remove unneeded variables used to store return values.

These issues were detected with the Coccinelle script:
scripts/coccinelle/misc/returnvar.cocci

[heiko.carstens@de.ibm.com]: make qeth_l[2/3]_stop() return void

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 3b974874

drivers/s390/cio/eadm_sch.c

+1 −2
Original line number Diff line number Diff line
@@ -336,7 +336,6 @@ static int eadm_subchannel_sch_event(struct subchannel *sch, int process) 
{

	struct eadm_private *private;

	unsigned long flags;

	int ret = 0;



	spin_lock_irqsave(sch->lock, flags);

	if (!device_is_registered(&sch->dev))
@@ -356,7 +355,7 @@ static int eadm_subchannel_sch_event(struct subchannel *sch, int process) 
out_unlock:

	spin_unlock_irqrestore(sch->lock, flags);



	return ret;

	return 0;

}



static struct css_device_id eadm_subchannel_ids[] = {

drivers/s390/net/qeth_l2_main.c

+1 −4
Original line number Diff line number Diff line
@@ -390,10 +390,8 @@ static int qeth_l2_vlan_rx_kill_vid(struct net_device *dev, 
	return rc;

}



static int qeth_l2_stop_card(struct qeth_card *card, int recovery_mode)

static void qeth_l2_stop_card(struct qeth_card *card, int recovery_mode)

{

	int rc = 0;



	QETH_DBF_TEXT(SETUP , 2, "stopcard");

	QETH_DBF_HEX(SETUP, 2, &card, sizeof(void *));
@@ -427,7 +425,6 @@ static int qeth_l2_stop_card(struct qeth_card *card, int recovery_mode) 
		qeth_clear_cmd_buffers(&card->read);

		qeth_clear_cmd_buffers(&card->write);

	}

	return rc;

}



static int qeth_l2_process_inbound_buffer(struct qeth_card *card,

drivers/s390/net/qeth_l3_main.c

+1 −4
Original line number Diff line number Diff line
@@ -2158,10 +2158,8 @@ static struct qeth_card *qeth_l3_get_card_from_dev(struct net_device *dev) 
	return card ;

}



static int qeth_l3_stop_card(struct qeth_card *card, int recovery_mode)

static void qeth_l3_stop_card(struct qeth_card *card, int recovery_mode)

{

	int rc = 0;



	QETH_DBF_TEXT(SETUP, 2, "stopcard");

	QETH_DBF_HEX(SETUP, 2, &card, sizeof(void *));
@@ -2196,7 +2194,6 @@ static int qeth_l3_stop_card(struct qeth_card *card, int recovery_mode) 
		qeth_clear_cmd_buffers(&card->read);

		qeth_clear_cmd_buffers(&card->write);

	}

	return rc;

}



/*