Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2dc4110 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij
Browse files

gpio: pca953x: remove incorrect le16_to_cpu calls 



i2c_smbus commands handle the correct byte order for smbus transactions
internally. This will currently result in incorrect operation on big
endian systems.

Suggested-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent ef954844

drivers/gpio/gpio-pca953x.c

+3 −5
Original line number Diff line number Diff line
@@ -187,10 +187,9 @@ static int pca953x_write_regs_8(struct pca953x_chip *chip, int reg, u8 *val) 


static int pca953x_write_regs_16(struct pca953x_chip *chip, int reg, u8 *val)

{

	__le16 word = cpu_to_le16(get_unaligned((u16 *)val));

	u16 word = get_unaligned((u16 *)val);



	return i2c_smbus_write_word_data(chip->client,

					 reg << 1, (__force u16)word);

	return i2c_smbus_write_word_data(chip->client, reg << 1, word);

}



static int pca957x_write_regs_16(struct pca953x_chip *chip, int reg, u8 *val)
@@ -241,8 +240,7 @@ static int pca953x_read_regs_16(struct pca953x_chip *chip, int reg, u8 *val) 
	int ret;



	ret = i2c_smbus_read_word_data(chip->client, reg << 1);

	val[0] = (u16)ret & 0xFF;

	val[1] = (u16)ret >> 8;

	put_unaligned(ret, (u16 *)val);



	return ret;

}