Commit b208ce32 authored Oct 09, 2014 by Rob Jones Committed by Linus Torvalds Oct 09, 2014

mm/slab.c: use __seq_open_private() instead of seq_open()



Using __seq_open_private() removes boilerplate code from slabstats_open()

The resultant code is shorter and easier to follow.

This patch does not change any functionality.

Signed-off-by: Rob Jones <rob.jones@codethink.co.uk>
Acked-by: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 703394c1

mm/slab.c

+9 −13

Original line number	Diff line number	Diff line
		@@ -4178,19 +4178,15 @@ static const struct seq_operations slabstats_op = {

		static int slabstats_open(struct inode inode, struct file file)
		{
		unsigned long *n = kzalloc(PAGE_SIZE, GFP_KERNEL);
		int ret = -ENOMEM;
		if (n) {
		ret = seq_open(file, &slabstats_op);
		if (!ret) {
		struct seq_file *m = file->private_data;
		unsigned long *n;

		n = __seq_open_private(file, &slabstats_op, PAGE_SIZE);
		if (!n)
		return -ENOMEM;

		n = PAGE_SIZE / (2 sizeof(unsigned long));
		m->private = n;
		n = NULL;
		}
		kfree(n);
		}
		return ret;

		return 0;
		}

		static const struct file_operations proc_slabstats_operations = {