Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1efa723 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

HID: add hid_is_usb() function to make it simpler for USB detection 



commit f83baa0cb6cfc92ebaf7f9d3a99d7e34f2e77a8a upstream.

A number of HID drivers already call hid_is_using_ll_driver() but only
for the detection of if this is a USB device or not.  Make this more
obvious by creating hid_is_usb() and calling the function that way.

Also converts the existing hid_is_using_ll_driver() functions to use the
new call.

Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
Cc: stable@vger.kernel.org
Tested-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20211201183503.2373082-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent df617829

drivers/hid/hid-asus.c

+1 −1
Original line number Diff line number Diff line
@@ -622,7 +622,7 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id) 
	if (drvdata->quirks & QUIRK_IS_MULTITOUCH)

		drvdata->tp = &asus_i2c_tp;



	if (drvdata->quirks & QUIRK_T100_KEYBOARD) {

	if ((drvdata->quirks & QUIRK_T100_KEYBOARD) && hid_is_usb(hdev)) {

		struct usb_interface *intf = to_usb_interface(hdev->dev.parent);



		if (intf->altsetting->desc.bInterfaceNumber == T100_TPAD_INTF) {

drivers/hid/wacom_sys.c

+1 −1
Original line number Diff line number Diff line
@@ -2188,7 +2188,7 @@ static void wacom_update_name(struct wacom *wacom, const char *suffix) 
	if ((features->type == HID_GENERIC) && !strcmp("Wacom HID", features->name)) {

		char *product_name = wacom->hdev->name;



		if (hid_is_using_ll_driver(wacom->hdev, &usb_hid_driver)) {

		if (hid_is_usb(wacom->hdev)) {

			struct usb_interface *intf = to_usb_interface(wacom->hdev->dev.parent);

			struct usb_device *dev = interface_to_usbdev(intf);

			product_name = dev->product;

include/linux/hid.h

+5 −0
Original line number Diff line number Diff line
@@ -834,6 +834,11 @@ static inline bool hid_is_using_ll_driver(struct hid_device *hdev, 
	return hdev->ll_driver == driver;

}



static inline bool hid_is_usb(struct hid_device *hdev)

{

	return hid_is_using_ll_driver(hdev, &usb_hid_driver);

}



#define	PM_HINT_FULLON	1<<5

#define PM_HINT_NORMAL	1<<1