Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1d353ad authored by Dan Carpenter's avatar Dan Carpenter Committed by Darren Hart
Browse files

intel_scu_ipcutil: underflow in scu_reg_access() 



"count" is controlled by the user and it can be negative.  Let's prevent
that by making it unsigned.  You have to have CAP_SYS_RAWIO to call this
function so the bug is not as serious as it could be.

Fixes: 5369c02d ('intel_scu_ipc: Utility driver for intel scu ipc')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
parent 1c319e78

drivers/platform/x86/intel_scu_ipcutil.c

+1 −1
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ struct scu_ipc_data { 


static int scu_reg_access(u32 cmd, struct scu_ipc_data  *data)

{

	int count = data->count;

	unsigned int count = data->count;



	if (count == 0 || count == 3 || count > 4)

		return -EINVAL;