Commit b18b7453 authored Apr 20, 2017 by Alexander Kochetkov Committed by David S. Miller Apr 21, 2017

net: arc_emac: switch to phy_start()/phy_stop()

Currently driver use phy_start_aneg() in arc_emac_open() to bring
up PHY. But phy_start() function is more appropriate for this purposes.
Besides that it call phy_start_aneg() as part of PHY startup sequence
it also can correctly bring up PHY from error and suspended states.
So the patch replace phy_start_aneg() to phy_start().

Also the patch add call to phy_stop() to arc_emac_stop() to allow
the PHY device to be fully suspended when the interface is unused.

Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6b633e82

drivers/net/ethernet/arc/emac_main.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -434,7 +434,7 @@ static int arc_emac_open(struct net_device *ndev)
		/* Enable EMAC */
		arc_reg_or(priv, R_CTRL, EN_MASK);

		phy_start_aneg(ndev->phydev);
		phy_start(ndev->phydev);

		netif_start_queue(ndev);

		@@ -556,6 +556,8 @@ static int arc_emac_stop(struct net_device *ndev)
		napi_disable(&priv->napi);
		netif_stop_queue(ndev);

		phy_stop(ndev->phydev);

		/* Disable interrupts */
		arc_reg_clr(priv, R_ENABLE, RXINT_MASK \| TXINT_MASK \| ERR_MASK);