Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b17f33cb authored by Lars Ellenberg's avatar Lars Ellenberg Committed by Philipp Reisner
Browse files

drbd: explicitly clear unused dp_flags in drbd_send_block 



We send left-over garbage from the previous packet in P_DATA_REPLY and
P_RS_DATA_REPLY packets. That's bad behaviour.

Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
parent 4d0fc3fd

drivers/block/drbd/drbd_main.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -1882,6 +1882,7 @@ int drbd_send_block(struct drbd_conf *mdev, enum drbd_packet cmd, 
	p->sector = cpu_to_be64(peer_req->i.sector);

	p->sector = cpu_to_be64(peer_req->i.sector);

	p->block_id = peer_req->block_id;

	p->block_id = peer_req->block_id;

	p->seq_num = 0;  /* unused */

	p->seq_num = 0;  /* unused */

	p->dp_flags = 0;

	if (dgs)

	if (dgs)

		drbd_csum_ee(mdev, mdev->tconn->integrity_tfm, peer_req, p + 1);

		drbd_csum_ee(mdev, mdev->tconn->integrity_tfm, peer_req, p + 1);

	err = __send_command(mdev->tconn, mdev->vnr, sock, cmd, sizeof(*p) + dgs, NULL, peer_req->i.size);

	err = __send_command(mdev->tconn, mdev->vnr, sock, cmd, sizeof(*p) + dgs, NULL, peer_req->i.size);