Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1116bc0 authored by Mike Marshall's avatar Mike Marshall
Browse files

orangefs: use sparse annotations for holding locks across function calls. 



Sparse complained and Al Viro knew what to do...

Signed-off-by: default avatarMike Marshall <hubcap@omnibond.com>
parent 3cf796af

fs/orangefs/waitqueue.c

+10 −4
Original line number Diff line number Diff line
@@ -17,8 +17,12 @@ 
#include "orangefs-kernel.h"

#include "orangefs-bufmap.h"



static int wait_for_matching_downcall(struct orangefs_kernel_op_s *, long, bool);

static void orangefs_clean_up_interrupted_operation(struct orangefs_kernel_op_s *);

static int wait_for_matching_downcall(struct orangefs_kernel_op_s *op,

		long timeout,

		bool interruptible)

			__acquires(op->lock);

static void orangefs_clean_up_interrupted_operation(struct orangefs_kernel_op_s *op)

	__releases(op->lock);



/*

 * What we do in this function is to walk the list of operations that are
@@ -246,6 +250,7 @@ bool orangefs_cancel_op_in_progress(struct orangefs_kernel_op_s *op) 
 */

static void

	orangefs_clean_up_interrupted_operation(struct orangefs_kernel_op_s *op)

		__releases(op->lock)

{

	/*

	 * handle interrupted cases depending on what state we were in when
@@ -315,6 +320,7 @@ static void 
static int wait_for_matching_downcall(struct orangefs_kernel_op_s *op,

		long timeout,

		bool interruptible)

			__acquires(op->lock)

{

	long n;