Commit b09eed7f authored Sep 01, 2016 by Sylwester Nawrocki Committed by Linus Walleij Sep 12, 2016

pinctrl: samsung: Remove an always false dev->of_node test



samsung_pinctrl_probe() can be called only after matching
the driver by the compatible string so this already implies
a non null dev->of_node.  Remove the always false test
and related error trace. While at it drop another error log
in case of memory allocation failure - any errors are logged
by the memory subsystem.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent c11a0442

drivers/pinctrl/samsung/pinctrl-samsung.c

+1 −9

Original line number	Diff line number	Diff line
		@@ -1041,17 +1041,9 @@ static int samsung_pinctrl_probe(struct platform_device *pdev)
		struct resource *res;
		int ret;

		if (!dev->of_node) {
		dev_err(dev, "device tree node not found\n");
		return -ENODEV;
		}

		drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);
		if (!drvdata) {
		dev_err(dev, "failed to allocate memory for driver's "
		"private data\n");
		if (!drvdata)
		return -ENOMEM;
		}

		ctrl = samsung_pinctrl_get_soc_data(drvdata, pdev);
		if (IS_ERR(ctrl)) {