Commit b09e71a8 authored Mar 09, 2013 by Antti Palosaari Committed by Mauro Carvalho Chehab Mar 23, 2013

[media] it913x: fix pid filter



I just made commit: "dvb_usb_v2: rework USB streaming logic" that
breaks that driver PID filter.
it913x driver checks use of PID filter directly from DVB USB v2 core
internal variable "adap->pid_filtering" and stores it to own state.
Calling order of .pid_filter_ctrl() and .pid_filter() was changed
and due to that state was updated too late. Update state earlier.
TODO: checking PID filter usage from DVB USB v2 is not very good idea
as PID filter callbacks are called only when PID filter is enabled.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 96d7ca5e

drivers/media/usb/dvb-usb-v2/it913x.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -218,6 +218,7 @@ static int it913x_pid_filter_ctrl(struct dvb_usb_adapter *adap, int onoff)

		deb_info(1, "PID_C (%02x)", onoff);

		st->pid_filter_onoff = adap->pid_filtering;
		ret = it913x_wr_reg(d, pro, PID_EN, st->pid_filter_onoff);

		mutex_unlock(&d->i2c_mutex);