Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b0753408 authored by Anton Vasilyev's avatar Anton Vasilyev Committed by David S. Miller
Browse files

net: mdio-mux: bcm-iproc: fix wrong getter and setter pair 



mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer
in device, whereas mdio_mux_iproc_remove() restores md pointer by
dev_get_platdata(&pdev->dev). This leads to wrong resources release.

The patch replaces getter to platform_get_drvdata.

Fixes: 98bc865a ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")
Signed-off-by: default avatarAnton Vasilyev <vasilyev@ispras.ru>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9fc12023

drivers/net/phy/mdio-mux-bcm-iproc.c

+1 −1
Original line number Diff line number Diff line
@@ -218,7 +218,7 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev) 


static int mdio_mux_iproc_remove(struct platform_device *pdev)

{

	struct iproc_mdiomux_desc *md = dev_get_platdata(&pdev->dev);

	struct iproc_mdiomux_desc *md = platform_get_drvdata(pdev);



	mdio_mux_uninit(md->mux_handle);

	mdiobus_unregister(md->mii_bus);