Commit afda0f94 authored May 01, 2012 by Namhyung Kim Committed by Arnaldo Carvalho de Melo May 01, 2012

perf build-id: Fix filename size calculation



The filename is a pointer variable so the sizeof(filename) will return
length of a pointer. Fix it by using 'size'.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1335881976-3282-1-git-send-email-namhyung@gmail.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 33ff581e

tools/perf/util/header.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -296,7 +296,7 @@ int build_id_cache__add_s(const char sbuild_id, const char debugdir,
		if (mkdir_p(filename, 0755))
		goto out_free;

		snprintf(filename + len, sizeof(filename) - len, "/%s", sbuild_id);
		snprintf(filename + len, size - len, "/%s", sbuild_id);

		if (access(filename, F_OK)) {
		if (is_kallsyms) {