Commit afb4c97d authored Dec 20, 2017 by Haishuang Yan Committed by David S. Miller Dec 20, 2017

ip6_gre: fix potential memory leak in ip6erspan_rcv



If md is NULL, tun_dst must be freed, otherwise it will cause memory
leak.

Fixes: ef7baf5e ("ip6_gre: add ip6 erspan collect_md mode")
Cc: William Tu <u9012063@gmail.com>
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 50670b6e

net/ipv6/ip6_gre.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -550,8 +550,10 @@ static int ip6erspan_rcv(struct sk_buff *skb, int gre_hdr_len,

		info = &tun_dst->u.tun_info;
		md = ip_tunnel_info_opts(info);
		if (!md)
		if (!md) {
		dst_release((struct dst_entry *)tun_dst);
		return PACKET_REJECT;
		}

		memcpy(md, pkt_md, sizeof(*md));
		md->version = ver;