Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af43c408 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jiri Kosina
Browse files

HID: rmi: fix some harmless BIT() mistakes 



These defines are used like this:

	if (!(test_bit(RMI_STARTED, &hdata->flags)))

So the intent was to use bits 0, 1 and 2 but because of the extra BIT()
shifts we're actually using 1, 2 and 4.  It's harmless because it's done
consistently but static checkers will complain.

Fixes: 9fb6bf02 ('HID: rmi: introduce RMI driver for Synaptics touchpads')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent d0091f57

drivers/hid/hid-rmi.c

+3 −3
Original line number Diff line number Diff line
@@ -29,9 +29,9 @@ 
#define RMI_SET_RMI_MODE_REPORT_ID	0x0f /* Feature Report */



/* flags */

#define RMI_READ_REQUEST_PENDING	BIT(0)

#define RMI_READ_DATA_PENDING		BIT(1)

#define RMI_STARTED			BIT(2)

#define RMI_READ_REQUEST_PENDING	0

#define RMI_READ_DATA_PENDING		1

#define RMI_STARTED			2



/* device flags */

#define RMI_DEVICE			BIT(0)