Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af2e2e35 authored by Julia Lawall's avatar Julia Lawall Committed by Roland Dreier
Browse files

IB/mlx4: Fix error return code 

Set the return variable to an error code as done elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent 7e22e911

drivers/infiniband/hw/mlx4/sysfs.c

+6 −2
Original line number Diff line number Diff line
@@ -582,8 +582,10 @@ static int add_port(struct mlx4_ib_dev *dev, int port_num, int slave) 
	p->pkey_group.attrs =

		alloc_group_attrs(show_port_pkey, store_port_pkey,

				  dev->dev->caps.pkey_table_len[port_num]);

	if (!p->pkey_group.attrs)

	if (!p->pkey_group.attrs) {

		ret = -ENOMEM;

		goto err_alloc;

	}



	ret = sysfs_create_group(&p->kobj, &p->pkey_group);

	if (ret)
@@ -591,8 +593,10 @@ static int add_port(struct mlx4_ib_dev *dev, int port_num, int slave) 


	p->gid_group.name  = "gid_idx";

	p->gid_group.attrs = alloc_group_attrs(show_port_gid_idx, NULL, 1);

	if (!p->gid_group.attrs)

	if (!p->gid_group.attrs) {

		ret = -ENOMEM;

		goto err_free_pkey;

	}



	ret = sysfs_create_group(&p->kobj, &p->gid_group);

	if (ret)