Commit aedd4fdf authored Dec 27, 2011 by Julia Lawall Committed by Grant Likely Jan 02, 2012

drivers/gpio/gpio-tegra.c: use devm_request_and_ioremap

Reimplement a call to devm_request_mem_region followed by a call to ioremap
or ioremap_nocache by a call to devm_request_and_ioremap.

The semantic patch that makes this transformation is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@nm@
expression myname;
identifier i;
@@

struct platform_driver i = { .driver = { .name = myname } };

@@
expression dev,res,size;
expression nm.myname;
@@

-if (!devm_request_mem_region(dev, res->start, size,
-                              \(res->name\|dev_name(dev)\|myname\))) {
-   ...
-   return ...;
-}
... when != res->start
(
-devm_ioremap(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
|
-devm_ioremap_nocache(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
)
... when any
    when != res->start
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

parent d0ad5e89

drivers/gpio/gpio-tegra.c

+1 −8

Original line number	Original line	Diff line number	Diff line
	@@ -361,14 +361,7 @@ static int __devinit tegra_gpio_probe(struct platform_device *pdev)
	return -ENODEV;		return -ENODEV;
	}		}

	if (!devm_request_mem_region(&pdev->dev, res->start,		regs = devm_request_and_ioremap(&pdev->dev, res);
	resource_size(res),
	dev_name(&pdev->dev))) {
	dev_err(&pdev->dev, "Couldn't request MEM resource\n");
	return -ENODEV;
	}

	regs = devm_ioremap(&pdev->dev, res->start, resource_size(res));
	if (!regs) {		if (!regs) {
	dev_err(&pdev->dev, "Couldn't ioremap regs\n");		dev_err(&pdev->dev, "Couldn't ioremap regs\n");
	return -ENODEV;		return -ENODEV;