Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae62e3d4 authored by Michael Krufky's avatar Michael Krufky Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (3575): Cxusb: fix i2c debug messages for bluebird devices 



Only the Medion boxes return 0x08 after an i2c read/write.
The bluebird devices do not return anything at all.
This patch conditionalizes the test for the 0x08 return code
to produce a warning message when using the Medion box, only.

Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent 4d6e772d

drivers/media/dvb/dvb-usb/cxusb.c

+2 −2
Original line number Diff line number Diff line
@@ -109,7 +109,7 @@ static int cxusb_i2c_xfer(struct i2c_adapter *adap,struct i2c_msg msg[],int num) 
				break;



			if (ibuf[0] != 0x08)

				deb_info("i2c read may have failed\n");

				deb_i2c("i2c read may have failed\n");



			memcpy(msg[i+1].buf,&ibuf[1],msg[i+1].len);
@@ -123,7 +123,7 @@ static int cxusb_i2c_xfer(struct i2c_adapter *adap,struct i2c_msg msg[],int num) 
			if (cxusb_ctrl_msg(d,CMD_I2C_WRITE, obuf, 2+msg[i].len, &ibuf,1) < 0)

				break;

			if (ibuf != 0x08)

				deb_info("i2c write may have failed\n");

				deb_i2c("i2c write may have failed\n");

		}

	}

drivers/media/dvb/dvb-usb/cxusb.h

+2 −0
Original line number Diff line number Diff line
@@ -6,6 +6,8 @@ 


extern int dvb_usb_cxusb_debug;

#define deb_info(args...)   dprintk(dvb_usb_cxusb_debug,0x01,args)

#define deb_i2c(args...)    if (d->udev->descriptor.idVendor == USB_VID_MEDION) \

				dprintk(dvb_usb_cxusb_debug,0x01,args)



/* usb commands - some of it are guesses, don't have a reference yet */

#define CMD_I2C_WRITE     0x08