Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad8cf035 authored by Dikshita Agarwal's avatar Dikshita Agarwal Committed by Greg Kroah-Hartman
Browse files

media: venus: fix use after free in vdec_close 



commit a0157b5aa34eb43ec4c5510f9c260bbb03be937e upstream.

There appears to be a possible use after free with vdec_close().
The firmware will add buffer release work to the work queue through
HFI callbacks as a normal part of decoding. Randomly closing the
decoder device from userspace during normal decoding can incur
a read after free for inst.

Fix it by cancelling the work in vdec_close.

Cc: stable@vger.kernel.org
Fixes: af2c3834 ("[media] media: venus: adding core part and helper functions")
Signed-off-by: default avatarDikshita Agarwal <quic_dikshita@quicinc.com>
Acked-by: default avatarVikash Garodia <quic_vgarodia@quicinc.com>
Signed-off-by: default avatarStanimir Varbanov <stanimir.k.varbanov@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a97e1082

drivers/media/platform/qcom/venus/vdec.c

+1 −0
Original line number Diff line number Diff line
@@ -1096,6 +1096,7 @@ static int vdec_close(struct file *file) 
{

	struct venus_inst *inst = to_inst(file);



	cancel_work_sync(&inst->delayed_process_work);

	v4l2_m2m_ctx_release(inst->m2m_ctx);

	v4l2_m2m_release(inst->m2m_dev);

	vdec_ctrl_deinit(inst);