Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad7bf428 authored by Hannes Eder's avatar Hannes Eder Committed by David S. Miller
Browse files

drivers/net/tokenring: fix sparse warning: cast truncates bits from const value 



Impact: Remove the write-only field 'current_ring_status' completely.

Fix this sparse warnings:
  drivers/net/tokenring/smctr.c:4410:52: warning: cast truncates bits from constant value (100 becomes 0)
  drivers/net/tokenring/smctr.c:4415:52: warning: cast truncates bits from constant value (400 becomes 0)
  drivers/net/tokenring/smctr.c:4420:52: warning: cast truncates bits from constant value (800 becomes 0)
  drivers/net/tokenring/smctr.c:4425:52: warning: cast truncates bits from constant value (1000 becomes 0)
  drivers/net/tokenring/smctr.c:4430:52: warning: cast truncates bits from constant value (2000 becomes 0)
  drivers/net/tokenring/smctr.c:4435:52: warning: cast truncates bits from constant value (4000 becomes 0)
  drivers/net/tokenring/smctr.c:4440:52: warning: cast truncates bits from constant value (8000 becomes 0)

Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7f50ca07

drivers/net/tokenring/smctr.c

+0 −10
Original line number Diff line number Diff line
@@ -4393,52 +4393,42 @@ static int smctr_ring_status_chg(struct net_device *dev) 
        {

                case RING_RECOVERY:

                        printk(KERN_INFO "%s: Ring Recovery\n", dev->name);

                        tp->current_ring_status |= RING_RECOVERY;

                        break;



                case SINGLE_STATION:

                        printk(KERN_INFO "%s: Single Statinon\n", dev->name);

                        tp->current_ring_status |= SINGLE_STATION;

                        break;



                case COUNTER_OVERFLOW:

                        printk(KERN_INFO "%s: Counter Overflow\n", dev->name);

                        tp->current_ring_status |= COUNTER_OVERFLOW;

                        break;



                case REMOVE_RECEIVED:

                        printk(KERN_INFO "%s: Remove Received\n", dev->name);

                        tp->current_ring_status |= REMOVE_RECEIVED;

                        break;



                case AUTO_REMOVAL_ERROR:

                        printk(KERN_INFO "%s: Auto Remove Error\n", dev->name);

                        tp->current_ring_status |= AUTO_REMOVAL_ERROR;

                        break;



                case LOBE_WIRE_FAULT:

                        printk(KERN_INFO "%s: Lobe Wire Fault\n", dev->name);

                        tp->current_ring_status |= LOBE_WIRE_FAULT;

                        break;



                case TRANSMIT_BEACON:

                        printk(KERN_INFO "%s: Transmit Beacon\n", dev->name);

                        tp->current_ring_status |= TRANSMIT_BEACON;

                        break;



                case SOFT_ERROR:

                        printk(KERN_INFO "%s: Soft Error\n", dev->name);

                        tp->current_ring_status |= SOFT_ERROR;

                        break;



                case HARD_ERROR:

                        printk(KERN_INFO "%s: Hard Error\n", dev->name);

                        tp->current_ring_status |= HARD_ERROR;

                        break;



                case SIGNAL_LOSS:

                        printk(KERN_INFO "%s: Signal Loss\n", dev->name);

                        tp->current_ring_status |= SIGNAL_LOSS;

                        break;



                default:

drivers/net/tokenring/smctr.h

+0 −1
Original line number Diff line number Diff line
@@ -977,7 +977,6 @@ typedef struct net_local { 
	__u8		monitor_state_ready;

	__u16		ring_status;

	__u8		ring_status_flags;

	__u8		current_ring_status;

	__u8		state;



	__u8		join_state;