Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad627017 authored by Bhumika Goyal's avatar Bhumika Goyal Committed by Mauro Carvalho Chehab
Browse files

[media] saa7146: make saa7146_use_ops const 



Make these const as they are not modified in the file referencing them.
They are only used when their function pointer fields invokes a
function and therefore none of the structure fields are getting modified.
Also, add a const to the declaration in the header.

Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 02256520

drivers/media/common/saa7146/saa7146_vbi.c

+1 −1
Original line number Diff line number Diff line
@@ -488,7 +488,7 @@ static ssize_t vbi_read(struct file *file, char __user *data, size_t count, loff 
	return ret;

}



struct saa7146_use_ops saa7146_vbi_uops = {

const struct saa7146_use_ops saa7146_vbi_uops = {

	.init		= vbi_init,

	.open		= vbi_open,

	.release	= vbi_close,

drivers/media/common/saa7146/saa7146_video.c

+1 −1
Original line number Diff line number Diff line
@@ -1303,7 +1303,7 @@ static ssize_t video_read(struct file *file, char __user *data, size_t count, lo 
	return ret;

}



struct saa7146_use_ops saa7146_video_uops = {

const struct saa7146_use_ops saa7146_video_uops = {

	.init = video_init,

	.open = video_open,

	.release = video_close,

include/media/drv-intf/saa7146_vv.h

+2 −2
Original line number Diff line number Diff line
@@ -202,14 +202,14 @@ void saa7146_set_gpio(struct saa7146_dev *saa, u8 pin, u8 data); 
/* from saa7146_video.c */

extern const struct v4l2_ioctl_ops saa7146_video_ioctl_ops;

extern const struct v4l2_ioctl_ops saa7146_vbi_ioctl_ops;

extern struct saa7146_use_ops saa7146_video_uops;

extern const struct saa7146_use_ops saa7146_video_uops;

int saa7146_start_preview(struct saa7146_fh *fh);

int saa7146_stop_preview(struct saa7146_fh *fh);

long saa7146_video_do_ioctl(struct file *file, unsigned int cmd, void *arg);

int saa7146_s_ctrl(struct v4l2_ctrl *ctrl);



/* from saa7146_vbi.c */

extern struct saa7146_use_ops saa7146_vbi_uops;

extern const struct saa7146_use_ops saa7146_vbi_uops;



/* resource management functions */

int saa7146_res_get(struct saa7146_fh *fh, unsigned int bit);