Commit ad0a596e authored Sep 25, 2019 by Dan Carpenter Committed by Greg Kroah-Hartman Jan 27, 2020

net: hisilicon: Fix signedness bug in hix5hd2_dev_probe()



[ Upstream commit 002dfe8085255b7bf1e0758c3d195c5412d35be9 ]

The "priv->phy_mode" variable is an enum and in this context GCC will
treat it as unsigned to the error handling will never trigger.

Fixes: 57c5bc9a ("net: hisilicon: add hix5hd2 mac driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent aaf27e4f

drivers/net/ethernet/hisilicon/hix5hd2_gmac.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1201,7 +1201,7 @@ static int hix5hd2_dev_probe(struct platform_device *pdev)
		goto err_free_mdio;

		priv->phy_mode = of_get_phy_mode(node);
		if (priv->phy_mode < 0) {
		if ((int)priv->phy_mode < 0) {
		netdev_err(ndev, "not find phy-mode\n");
		ret = -EINVAL;
		goto err_mdiobus;