Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acfead32 authored by Mikulas Patocka's avatar Mikulas Patocka Committed by David S. Miller
Browse files

ide: don't call memcpy with the same source and destination 



The parisc architecture recently reimplemented the memcpy function and
their reimplementation crashed when source and destination overlapped.

The crash happened in the function ide_complete_cmd where memcpy is called
with the same source and destination pointer. According to the C
specification, memcpy behavior is undefined if the source and destination
range overlaps. This patches fixes the undefined behavior.

Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Reviewed-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1a1df90a

drivers/ide/ide-io.c

+1 −1
Original line number Diff line number Diff line
@@ -107,7 +107,7 @@ void ide_complete_cmd(ide_drive_t *drive, struct ide_cmd *cmd, u8 stat, u8 err) 


		if (cmd->tf_flags & IDE_TFLAG_DYN)

			kfree(orig_cmd);

		else

		else if (cmd != orig_cmd)

			memcpy(orig_cmd, cmd, sizeof(*cmd));

	}

}