Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acd9362c authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: add likely/unlikely comparison misuse test 



Add a test for probably likely/unlikely misuses where the comparison is
likely misplaced

	if (likely(foo) > 0)
vs
	if (likely(foo > 0))

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Cc: Christoph Jaeger <cj@linux.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0d7835fc

scripts/checkpatch.pl

+7 −0
Original line number Diff line number Diff line
@@ -5239,6 +5239,13 @@ sub process { 
			      "#define of '$1' is wrong - use Kconfig variables or standard guards instead\n" . $herecurr);

		}



# likely/unlikely comparisons similar to "(likely(foo) > 0)"

		if ($^V && $^V ge 5.10.0 &&

		    $line =~ /\b((?:un)?likely)\s*\(\s*$FuncArg\s*\)\s*$Compare/) {

			WARN("LIKELY_MISUSE",

			     "Using $1 should generally have parentheses around the comparison\n" . $herecurr);

		}



# whine mightly about in_atomic

		if ($line =~ /\bin_atomic\s*\(/) {

			if ($realfile =~ m@^drivers/@) {