Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acb2cc8b authored by Mariusz Kozlowski's avatar Mariusz Kozlowski Committed by David S. Miller
Browse files

[PATCH] drivers/net: remove superfluous memset 



	This patch covers something like this:

dev = alloc_*dev(...
...
priv = netdev_priv(dev);
memset(priv, 0, sizeof(*priv));

The memset() here is superfluous. alloc_netdev() uses kzalloc()
to allocate needed memory so there is no need to zero the priv region
twice.

Signed-off-by: default avatarMariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bf1e9a08

drivers/net/fs_enet/fs_enet-main.c

+0 −1
Original line number Diff line number Diff line
@@ -956,7 +956,6 @@ static struct net_device *fs_init_instance(struct device *dev, 
	SET_MODULE_OWNER(ndev);



	fep = netdev_priv(ndev);

	memset(fep, 0, privsize);	/* clear everything */



	fep->dev = dev;

	dev_set_drvdata(dev, ndev);

drivers/net/myri10ge/myri10ge.c

+0 −1
Original line number Diff line number Diff line
@@ -2956,7 +2956,6 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	SET_NETDEV_DEV(netdev, &pdev->dev);



	mgp = netdev_priv(netdev);

	memset(mgp, 0, sizeof(*mgp));

	mgp->dev = netdev;

	netif_napi_add(netdev, &mgp->napi,

		       myri10ge_poll, myri10ge_napi_weight);

drivers/net/netxen/netxen_nic_main.c

+0 −1
Original line number Diff line number Diff line
@@ -329,7 +329,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	SET_NETDEV_DEV(netdev, &pdev->dev);



	adapter = netdev->priv;

	memset(adapter, 0 , sizeof(struct netxen_adapter));



	adapter->ahw.pdev = pdev;

	adapter->ahw.pci_func  = pci_func_id;

drivers/net/sunlance.c

+0 −1
Original line number Diff line number Diff line
@@ -1335,7 +1335,6 @@ static int __devinit sparc_lance_probe_one(struct sbus_dev *sdev, 
		return -ENOMEM;



	lp = netdev_priv(dev);

	memset(lp, 0, sizeof(*lp));



	if (sparc_lance_debug && version_printed++ == 0)

		printk (KERN_INFO "%s", version);

drivers/net/usb/pegasus.c

+0 −1
Original line number Diff line number Diff line
@@ -1306,7 +1306,6 @@ static int pegasus_probe(struct usb_interface *intf, 
	}



	pegasus = netdev_priv(net);

	memset(pegasus, 0, sizeof (struct pegasus));

	pegasus->dev_index = dev_index;

	init_waitqueue_head(&pegasus->ctrl_wait);