Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acae7d90 authored Jun 06, 2008 by Maciej W. Rozycki Committed by Ingo Molnar Jul 08, 2008

x86: APIC/UP: Downgrade the NMI watchdog for no I/O APIC

If configured to use the I/O APIC, the NMI watchdog is deemed to fail if
the chip will not be used in the UP configuration, because "noapic" has
been specified or the chip is simply not there. Downgrade to the local
APIC watchdog to rectify.

The new #ifdef is ugly, I know. A proper solution is to provide suitable
definitions of smp_found_config, etc. for !CONFIG_X86_IO_APIC in a header.
Likewise the whole if () condition should be moved to a static inline
function. Such clean-ups are beyond the scope of this change and can be
done once the whole issue of the timer has been sorted out.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 148b5083

arch/x86/kernel/apic_32.c

+4 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1269,6 +1269,10 @@ int __init APIC_init_uniprocessor(void)

	setup_local_APIC();		setup_local_APIC();

			#ifdef CONFIG_X86_IO_APIC
			if (!smp_found_config \|\| skip_ioapic_setup \|\| !nr_ioapics)
			#endif
			localise_nmi_watchdog();
	end_local_APIC_setup();		end_local_APIC_setup();
	#ifdef CONFIG_X86_IO_APIC		#ifdef CONFIG_X86_IO_APIC
	if (smp_found_config)		if (smp_found_config)

arch/x86/kernel/apic_64.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -954,6 +954,8 @@ int __init APIC_init_uniprocessor(void)
	if (!skip_ioapic_setup && nr_ioapics)		if (!skip_ioapic_setup && nr_ioapics)
	enable_IO_APIC();		enable_IO_APIC();

			if (!smp_found_config \|\| skip_ioapic_setup \|\| !nr_ioapics)
			localise_nmi_watchdog();
	end_local_APIC_setup();		end_local_APIC_setup();

	if (smp_found_config && !skip_ioapic_setup && nr_ioapics)		if (smp_found_config && !skip_ioapic_setup && nr_ioapics)