Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit abbf268a authored by Russell King's avatar Russell King Committed by Russell King
Browse files

[DRIVER MODEL] Fix gbefb 



Statically allocated devices in module data is a potential cause
of oopsen.  The device may be in use by a userspace process, which
will keep a reference to the device.  If the module is unloaded,
the module data will be freed.  Subsequent use of the platform
device will cause a kernel oops.

Use generic platform device allocation/release code in modules.

Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 8d972a96

drivers/video/gbefb.c

+12 −6
Original line number Diff line number Diff line
@@ -1260,23 +1260,29 @@ static struct device_driver gbefb_driver = { 
	.remove = __devexit_p(gbefb_remove),

};



static struct platform_device gbefb_device = {

	.name = "gbefb",

};

static struct platform_device *gbefb_device;



int __init gbefb_init(void)

{

	int ret = driver_register(&gbefb_driver);

	if (!ret) {

		ret = platform_device_register(&gbefb_device);

		if (ret)

		gbefb_device = platform_device_alloc("gbefb", 0);

		if (gbefb_device) {

			ret = platform_device_add(gbefb_device);

		} else {

			ret = -ENOMEM;

		}

		if (ret) {

			platform_device_put(gbefb_device);

			driver_unregister(&gbefb_driver);

		}

	}

	return ret;

}



void __exit gbefb_exit(void)

{

	platform_device_unregister(gbefb_device);

	driver_unregister(&gbefb_driver);

}