Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab1b7ada authored by Bartlomiej Zolnierkiewicz's avatar Bartlomiej Zolnierkiewicz Committed by Eduardo Valentin
Browse files

thermal: exynos: do not use trips structure directly in ->tmu_initialize 



Use ->get_trip_[temp,hyst] methods instead of using trips structure
directly in all ->tmu_initialize method implementations.

There should be no functional changes caused by this patch.

Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Reviewed-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent a503a10f

drivers/thermal/samsung/exynos_tmu.c

+8 −10
Original line number Diff line number Diff line
@@ -409,15 +409,13 @@ static void exynos4210_tmu_initialize(struct platform_device *pdev) 
{

	struct exynos_tmu_data *data = platform_get_drvdata(pdev);

	struct thermal_zone_device *tz = data->tzd;

	const struct thermal_trip * const trips =

		of_thermal_get_trip_points(tz);

	unsigned long temp;

	int i;

	int i, temp;



	sanitize_temp_error(data, readl(data->base + EXYNOS_TMU_REG_TRIMINFO));



	for (i = 0; i < of_thermal_get_ntrips(tz); i++) {

		temp = trips[i].temperature / MCELSIUS;

		tz->ops->get_trip_temp(tz, i, &temp);

		temp /= MCELSIUS;

		exynos4210_tmu_set_trip_temp(data, i, temp);

	}

}
@@ -455,11 +453,9 @@ static void exynos4412_tmu_initialize(struct platform_device *pdev) 
{

	struct exynos_tmu_data *data = platform_get_drvdata(pdev);

	struct thermal_zone_device *tz = data->tzd;

	const struct thermal_trip * const trips =

		of_thermal_get_trip_points(tz);

	unsigned long temp, hyst;

	unsigned int trim_info, ctrl;

	int i, ntrips = min_t(int, of_thermal_get_ntrips(tz), data->ntrip);

	int temp, hyst;



	if (data->soc == SOC_ARCH_EXYNOS3250 ||

	    data->soc == SOC_ARCH_EXYNOS4412 ||
@@ -484,10 +480,12 @@ static void exynos4412_tmu_initialize(struct platform_device *pdev) 


	/* Write temperature code for rising and falling threshold */

	for (i = 0; i < ntrips; i++) {

		temp = trips[i].temperature / MCELSIUS;

		tz->ops->get_trip_temp(tz, i, &temp);

		temp /= MCELSIUS;

		exynos4412_tmu_set_trip_temp(data, i, temp);



		hyst = trips[i].hysteresis / MCELSIUS;

		tz->ops->get_trip_hyst(tz, i, &hyst);

		hyst /= MCELSIUS;

		exynos4412_tmu_set_trip_hyst(data, i, temp, hyst);

	}

}