Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aafddbf0 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

fq_codel: return non zero qlen in class dumps 



We properly scan the flow list to count number of packets,
but John passed 0 to gnet_stats_copy_queue() so we report
a zero value to user space instead of the result.

Fixes: 64015853 ("net: sched: restrict use of qstats qlen")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: John Fastabend <john.r.fastabend@intel.com>
Acked-by: default avatarJohn Fastabend <john.r.fastabend@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 064d5e6f

net/sched/sch_fq_codel.c

+1 −1
Original line number Diff line number Diff line
@@ -661,7 +661,7 @@ static int fq_codel_dump_class_stats(struct Qdisc *sch, unsigned long cl, 
		qs.backlog = q->backlogs[idx];

		qs.drops = flow->dropped;

	}

	if (gnet_stats_copy_queue(d, NULL, &qs, 0) < 0)

	if (gnet_stats_copy_queue(d, NULL, &qs, qs.qlen) < 0)

		return -1;

	if (idx < q->flows_cnt)

		return gnet_stats_copy_app(d, &xstats, sizeof(xstats));