Commit aa08e30c authored Sep 25, 2019 by Dan Carpenter Committed by Greg Kroah-Hartman Jan 27, 2020

of: mdio: Fix a signedness bug in of_phy_get_and_connect()



[ Upstream commit d7eb651212fdbafa82d485d8e76095ac3b14c193 ]

The "iface" variable is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.

Fixes: b7862412 ("of_mdio: Abstract a general interface for phy connect")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent bb8179ad

drivers/of/of_mdio.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -370,7 +370,7 @@ struct phy_device of_phy_get_and_connect(struct net_device dev,
	int ret;		int ret;

	iface = of_get_phy_mode(np);		iface = of_get_phy_mode(np);
	if (iface < 0)		if ((int)iface < 0)
	return NULL;		return NULL;
	if (of_phy_is_fixed_link(np)) {		if (of_phy_is_fixed_link(np)) {
	ret = of_phy_register_fixed_link(np);		ret = of_phy_register_fixed_link(np);